Start using emplace_back

OpenShock · Nov 21, 2024 · 4a3bd1c · 4a3bd1c · github-actions · Nov 21, 2024
1 parent 92559fc
commit 4a3bd1c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/src/OtaUpdateManager.cpp b/src/OtaUpdateManager.cpp
@@ -450,7 +450,7 @@ static bool _tryGetStringList(std::string_view url, std::vector<std::string>& li
       continue;
     }
 
-    list.push_back(std::string(line));
+    list.emplace_back(line);
   }
 
   return true;

diff --git a/src/config/Config.cpp b/src/config/Config.cpp
@@ -495,11 +495,7 @@ uint8_t Config::AddWiFiCredentials(std::string_view ssid, std::string_view passw
     return 0;
   }
 
-  _configData.wifi.credentialsList.push_back({
-    .id       = id,
-    .ssid     = std::string(ssid),
-    .password = std::string(password),
-  });
+  _configData.wifi.credentialsList.emplace_back(id, ssid, password);
   _trySaveConfig();
 
   return id;

diff --git a/src/serial/command_handlers/CommandEntry.cpp b/src/serial/command_handlers/CommandEntry.cpp
@@ -14,7 +14,7 @@ CommandEntry::CommandEntry(std::string_view name, std::string_view description,
 }
 
 CommandArgument& CommandEntry::addArgument(std::string_view name, std::string_view constraint, std::string_view exampleValue, std::vector<std::string_view> constraintExtensions) {
-  m_arguments.push_back(CommandArgument {name, constraint, exampleValue, constraintExtensions});
+  m_arguments.push_back({name, constraint, exampleValue, constraintExtensions});
   return m_arguments.back();
 }
 
@@ -23,13 +23,11 @@ CommandGroup::CommandGroup(std::string_view name)
 }
 
 CommandEntry& CommandGroup::addCommand(std::string_view description, CommandHandler commandHandler) {
-  auto cmd = CommandEntry(description, commandHandler);
-  m_commands.push_back(cmd);
+  m_commands.emplace_back(description, commandHandler);
   return m_commands.back();
 }
 
 CommandEntry& CommandGroup::addCommand(std::string_view name, std::string_view description, CommandHandler commandHandler) {
-  auto cmd = CommandEntry(name, description, commandHandler);
-  m_commands.push_back(cmd);
+  m_commands.emplace_back(name, description, commandHandler);
   return m_commands.back();
 }