Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update object string dumps #2957

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Update object string dumps #2957

merged 3 commits into from
Nov 8, 2024

Conversation

AaronVanGeffen
Copy link
Member

@AaronVanGeffen AaronVanGeffen commented Oct 30, 2024

With the scenario text PR in, this PR updates the object string dumps for all languages, sorted by object id.

This PR as a whole has a pretty terrible diff, as the previous dump was apparently not ordered by id. The first commit orders the files in-tree by object identifier key, while the second commit brings the dumps up-to-date.

This comment was marked as outdated.

@Gymnasiast
Copy link
Member

I want to be able to see if this doesn’t accidentally overwrite any existing translations.

I want to do that as follows:

  • Take the existing JSON files
  • Sort them
  • Merge it
  • Rebase this on top of that.

@AaronVanGeffen
Copy link
Member Author

I can easily do that (jq --sort-keys) and just regenerate the dumps, if you like.

@Gymnasiast
Copy link
Member

Yes, please.

This comment was marked as outdated.

This comment was marked as outdated.

@Gymnasiast
Copy link
Member

Gymnasiast commented Nov 2, 2024

Could you re-dump to account for the changed IDs? I already merged the "sort" commit.

This comment was marked as outdated.

This comment was marked as resolved.

Copy link

github-actions bot commented Nov 5, 2024

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 182 1 1765
ca-ES 49 0 83
cs-CZ 186 0 140
da-DK 91 0 238
de-DE 2 0 141
en-US 3403 0 1
eo-ZZ 0 0 65
es-ES 37 0 159
fi-FI 2 0 96
fr-CA 3559 0 0
fr-FR 51 0 134
hu-HU 2 0 86
it-IT 0 0 133
ja-JP 2 0 121
ko-KR 0 0 89
nb-NO 91 0 163
nl-NL 2 0 174
pl-PL 0 0 104
pt-BR 2 0 132
ru-RU 1105 0 65
sv-SE 56 0 150
tr-TR 420 0 98
uk-UA 86 33 725
vi-VN 282 2 2788
zh-CN 66 0 30
zh-TW 177 0 105

@AaronVanGeffen
Copy link
Member Author

AaronVanGeffen commented Nov 5, 2024

Updated the dumps using the branch for OpenRCT2/objects#353, i.e. taking the new Polish translations from #2964 into account. NB: not #2966, so please merge this first.

@Gymnasiast
Copy link
Member

Apologies, I already merged #2966 before I saw your request.

@AaronVanGeffen
Copy link
Member Author

Thankfully, there doesn't seem to be a conflict. Phew! I'm just glad I don't have to do it over again 😄

objects/pl-PL.json Outdated Show resolved Hide resolved
objects/pl-PL.json Outdated Show resolved Hide resolved
objects/pl-PL.json Outdated Show resolved Hide resolved
objects/pl-PL.json Outdated Show resolved Hide resolved
objects/pl-PL.json Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 8, 2024

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 182 1 1765
ca-ES 49 0 83
cs-CZ 186 0 140
da-DK 91 0 238
de-DE 2 0 141
en-US 3403 0 1
eo-ZZ 0 0 65
es-ES 37 0 159
fi-FI 2 0 96
fr-CA 3559 0 0
fr-FR 51 0 134
hu-HU 2 0 86
it-IT 0 0 133
ja-JP 2 0 121
ko-KR 0 0 89
nb-NO 91 0 163
nl-NL 2 0 174
pl-PL 0 0 104
pt-BR 2 0 132
ru-RU 1105 0 65
sv-SE 56 0 150
tr-TR 420 0 98
uk-UA 86 33 725
vi-VN 282 2 2788
zh-CN 66 0 30
zh-TW 177 0 105

objects/de-DE.json Outdated Show resolved Hide resolved
objects/de-DE.json Outdated Show resolved Hide resolved
objects/de-DE.json Outdated Show resolved Hide resolved
objects/fi-FI.json Outdated Show resolved Hide resolved
objects/zh-CN.json Outdated Show resolved Hide resolved
Copy link

github-actions bot commented Nov 8, 2024

Check results

For details go to Translation Check -> Details. Expand Run checks build stage and use the build-in search to find your language (e.g. pl-PL)

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

Other translations

MissingThe translation is not added to translation file. (e.g. STR_9999 is in en-GB but is not available in given language)

Not neededThe translation file contains entries that are not in en-GB and should be removed (e.g. STR_9999 exists in given language but is not in en-GB)

SameThe translation and source string is exactly the same. (e.g. STR_9999 is Umbrella in both en-GB and given language). This may be desired in some cases (e.g. April is the same in English and German)

ar-EG 182 1 1765
ca-ES 49 0 83
cs-CZ 186 0 140
da-DK 91 0 238
de-DE 2 0 141
en-US 3403 0 1
eo-ZZ 0 0 65
es-ES 37 0 159
fi-FI 2 0 96
fr-CA 3559 0 0
fr-FR 51 0 134
hu-HU 2 0 86
it-IT 0 0 133
ja-JP 2 0 121
ko-KR 0 0 89
nb-NO 91 0 163
nl-NL 2 0 174
pl-PL 0 0 104
pt-BR 2 0 132
ru-RU 1105 0 65
sv-SE 56 0 150
tr-TR 420 0 98
uk-UA 86 33 725
vi-VN 282 2 2788
zh-CN 66 0 30
zh-TW 177 0 105

@Gymnasiast Gymnasiast merged commit 06d9662 into master Nov 8, 2024
1 check passed
@Gymnasiast Gymnasiast deleted the object-dumps branch November 8, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants