scheduler: Set reasons in cupsdSetJobState only if we call finalize_j… #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelrsweet
previously approved these changes
Nov 23, 2023
|
I'll just make one change - we have to be sure that we have 'job' before calling the ippSetString, since we dereference it - I blindly negated the conditions which have to be fulfilled to get to finalize_job() and we shouldn't get here if job is NULL, but just to make sure that it is clear we have to have job there... |
zdohnal
commented
Nov 24, 2023
There was a problem hiding this comment.
I've just use the same condition as we have for calling finalize_job(), so it matches the comment and intention (idk why I did the cond negation previously...) - I had to change it because I realize we should guard against job being NULL there, since we dereference the job.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Nov 27, 2023
Before OpenPrinting#832 most successfully finished jobs had incorrect job state reasons - try to fix them during loading the jobs.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Jan 19, 2024
Before OpenPrinting#832 most successfully finished jobs had incorrect job state reasons - try to fix them during loading the jobs.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Jan 19, 2024
Before OpenPrinting#832 most successfully finished jobs had incorrect job state reasons - try to fix them during loading the jobs.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Jan 26, 2024
Before OpenPrinting#832 most successfully finished jobs had incorrect job state reasons - try to fix them during loading the jobs.
zdohnal
added a commit
to zdohnal/cups
that referenced
this pull request
Jan 26, 2024
Before OpenPrinting#832 most successfully finished jobs had incorrect job state reasons - try to fix them during loading the jobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ob later
Before the fix, every successfully printed jobs ended up with 'processing-to-stop-point' as the last reasons message.
Together with #830 fixes #828 .