Simplify bounds checks #701
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AZero13
force-pushed
the
bounds
branch
8 times, most recently
from
f4ec2aa to
594271c
Compare
|
Honestly, I don't see this as improving, simplifying, or fixing anything. I'll hold this for potential incorporation into 2.5 but no promises. |
AZero13
force-pushed
the
bounds
branch
5 times, most recently
from
e4a673d to
bfaa423
Compare
AZero13
force-pushed
the
bounds
branch
2 times, most recently
from
d05b0b3 to
f331dae
Compare
AZero13
force-pushed
the
bounds
branch
7 times, most recently
from
7d77ba8 to
b0e1f2f
Compare
AZero13
force-pushed
the
bounds
branch
6 times, most recently
from
9d8721d to
449ecd6
Compare
|
Updated @michaelrsweet |
We can save a lot of work this way.
|
Still not convinced this is necessary. Sorry, but closing... |
michaelrsweet
added
wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can save a lot of work this way.
Also, detect truncation in strlcpy.