Merge pull request #143 from OpenPEPPOL/2023-q4-member-review

2023 q4 member review
OpenPEPPOL · Nov 27, 2023 · 22c8792 · 22c8792
2 parents c933243 + e259f10
commit 22c8792
Show file tree

Hide file tree

Showing 17 changed files with 329 additions and 132 deletions.
diff --git a/.github/workflows/build-and-deploy-barnch.yml b/.github/workflows/build-and-deploy-barnch.yml
@@ -19,4 +19,4 @@ jobs:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}
         run: |
-          aws s3 sync --acl public-read --region eu-west-1 target/site ${{ secrets.AWS_S3_PATH }}/poacc/${GITHUB_REF#refs/heads/}/billing/3.0
+          aws s3 sync --acl public-read --region eu-west-1 target/site ${{ secrets.AWS_S3_PATH }}/poacc/billing/3.0/${GITHUB_REF#refs/heads/}
diff --git a/guide/profile/codes/invoice-specific.adoc b/guide/profile/codes/invoice-specific.adoc
@@ -63,6 +63,12 @@ include::../../syntax/codelists/inv-type.adoc[]
 | 380
 | Invoice
 
+|326
+|Partial invoice
+|Document/message specifying details of an incomplete invoice.
+| 380
+| Invoice
+
 |331
 |Commercial invoice which includes a packing list
 |Commercial transaction (invoice) will include a packing list.
@@ -81,6 +87,12 @@ include::../../syntax/codelists/inv-type.adoc[]
 | 380
 | Invoice
 
+|384
+|Corrected invoice
+|Commercial invoice that includes revised information differing from an earlier submission of the same invoice.
+| 380
+| Invoice
+
 |386
 |Prepayment invoice
 |An invoice to pay amounts for goods and services in advance; these amounts will be subtracted from the final invoice.

diff --git a/guide/release-notes/main.adoc b/guide/release-notes/main.adoc
@@ -15,6 +15,8 @@ IMPORTANT: Changes in code lists are also reflected by changes in the validation
 
 :leveloffset: +1
 
+include::v3.0.16.adoc[]
+
 include::v3.0.15.adoc[]
 
 include::v3.0.14.adoc[]

diff --git a/guide/release-notes/v3.0.16.adoc b/guide/release-notes/v3.0.16.adoc
@@ -0,0 +1,33 @@
+= Version 3.0.16
+[horizontal]
+Release date:: 2023-11-01
+
+== Changes to BIS document
+
+* A recommendation has been added to the Sales Order Reference element for handling cases where there is no Purchase Order Reference. This clarifies what to do with the mandatory UBL element for Purchase Order Reference. Example file is added which illustrates this.
+
+* Text in section 4.6 on negative invoices edited to remove historic comparison to BIS2 and justification for the change. No functional change.
+
+== Changes to code lists and validation artefacts
+
+* The validation rule identified as PEPPOL-EN16931-R006, which ensures that only one Invoice Object is allowed at the document level in an invoice/credit note, has been removed. This is because it duplicates the European standard rule UBL-SR-04, making it redundant and unnecessary.
+
+* The structure of the Peppol Schematron rule set has been improved for better quality. A function that was previously located in the Greek rules section is now correctly positioned alongside other functions.
+
+* Added invoice type codes 326 "Partial invoice" and 384 "Corrected invoice" as synonyms to code 380.
+
+==  EN 16931 schematrons updated
+* Adopted version 1.3.11 of EN 16931 validation artefacts (# numbers refer to EN GitHub issues).
+** Cardinality of DesignatedProductClassification in CII might stop the check BR-65 #355
+** CII Missing check on DefinedTradeContact cardinality #354
+** CII BT-17 and BT-18 checks to be improved #353
+** UBL-SR-43 using attribute scheme instead of schemeID #351
+** CII - missing cardinality check for ApplicableTradeTax (BG-30) #349
+** Error in Validation of Rule BR-E-08 #348
+** UBL-SR-51 does not check cac:DeliveryLocation #347
+** Typo in rule-text UBL-CR-282, UBL-CR-247 and UBL-CR-183 (UBL) #346
+** Typo in rule-text UBL-CR-583, UBL-CR-577 and UBL-CR-572 (UBL) #345
+** BR-17 rule checks too hard? #344
+** CII - missing cardinality check for SpecifiedTradePaymentTerms #343
+** add missing currency codes #356
+** Add EAS Code 0218 list #359
diff --git a/guide/transaction-spec/functionality/negative-invoices.adoc b/guide/transaction-spec/functionality/negative-invoices.adoc
@@ -2,21 +2,15 @@
 = Negative invoices and credit notes
 
 
-In line with requirements of {EN16931} this BIS supports negative grand totals. This represents a significant change in comparison to {openpeppol}’s previous specifications where invoices and credit notes have non-negative total.
-
-The argument for negative invoices is to open up for a wider spectrum of invoicing processes.
+In line with requirements of {EN16931} this BIS supports negative grand totals in order to open up for a wider spectrum of invoicing processes.
 
 Examples of such processes are
 
-*	Preliminary (estimated) consumption invoice that is balanced out in a later meter-based invoice;
-*	Pre-payment (with or without VAT) is settled through a final invoice; and
+* Preliminary (estimated) consumption invoice that is balanced out in a later meter-based invoice;
+* Pre-payment (with or without VAT) is settled through a final invoice; and
 * Some user communities prefer to use negative invoice rather than credit note when correcting transactions.
 
-====
-NOTE: Buyers who value automatic matching of e-invoices to orders or invoicing objects may wish to limit the areas and situations where complex transactions can be accepted and voice their requirements at time of procurement.
-====
-
-The decision has the following implications on the transaction format:
+This has the following implications on the transaction format:
 
 * The invoice (now with “negative invoice capacity”) can function as an alternative to the credit note. Invoice-generating systems may implement either option, while invoice-receiving systems have to support both of them.
 *	The transaction format for credit note has to be designed to accommodate for negative grand total, as well; this is because an entire negative invoice may have to be balanced out by means of a credit note.

diff --git a/project.xml b/project.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <Project xmlns="urn:fdc:difi.no:2017:vefa:structure:Project-1">
 
-    <Name>Peppol BIS Billing 3.0 - May 2023 Release</Name>
+    <Name>Peppol BIS Billing 3.0 - November 2023 Release - MEMBER REVIEW</Name>
 
     <Documentation path="bis/">Business Interoperability Specifications (BIS)</Documentation>
     <Documentation path="compliance/">BIS compliance</Documentation>

diff --git a/rules/examples/sales-order-example.xml b/rules/examples/sales-order-example.xml
@@ -0,0 +1,214 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<Invoice xmlns:cac="urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2"
+    xmlns:cbc="urn:oasis:names:specification:ubl:schema:xsd:CommonBasicComponents-2"
+    xmlns="urn:oasis:names:specification:ubl:schema:xsd:Invoice-2">
+    <cbc:CustomizationID>urn:cen.eu:en16931:2017#compliant#urn:fdc:peppol.eu:2017:poacc:billing:3.0</cbc:CustomizationID>
+    <cbc:ProfileID>urn:fdc:peppol.eu:2017:poacc:billing:01:1.0</cbc:ProfileID>
+    <cbc:ID>Snippet1</cbc:ID>
+    <cbc:IssueDate>2017-11-13</cbc:IssueDate>
+    <cbc:DueDate>2017-12-01</cbc:DueDate>
+    <cbc:InvoiceTypeCode>380</cbc:InvoiceTypeCode>
+    <cbc:DocumentCurrencyCode>EUR</cbc:DocumentCurrencyCode>
+    <cbc:AccountingCost>4025:123:4343</cbc:AccountingCost>
+    <cbc:BuyerReference>0150abc</cbc:BuyerReference>
+	<cac:OrderReference>
+		<cbc:ID>NA</cbc:ID><!-- NA can be provided if there is no purchase order and only a sales order, as the chc:ID element is mandatory -->
+		<cbc:SalesOrderID>123456</cbc:SalesOrderID>
+	</cac:OrderReference>	
+    <cac:AccountingSupplierParty>
+        <cac:Party>
+            <cbc:EndpointID schemeID="0088">9482348239847239874</cbc:EndpointID>
+            <cac:PartyIdentification>
+                <cbc:ID>99887766</cbc:ID>
+            </cac:PartyIdentification>
+            <cac:PartyName>
+                <cbc:Name>SupplierTradingName Ltd.</cbc:Name>
+            </cac:PartyName>
+            <cac:PostalAddress>
+                <cbc:StreetName>Main street 1</cbc:StreetName>
+                <cbc:AdditionalStreetName>Postbox 123</cbc:AdditionalStreetName>
+                <cbc:CityName>London</cbc:CityName>
+                <cbc:PostalZone>GB 123 EW</cbc:PostalZone>
+                <cac:Country>
+                    <cbc:IdentificationCode>GB</cbc:IdentificationCode>
+                </cac:Country>
+            </cac:PostalAddress>
+            <cac:PartyTaxScheme>
+                <cbc:CompanyID>GB1232434</cbc:CompanyID>
+                <cac:TaxScheme>
+                    <cbc:ID>VAT</cbc:ID>
+                </cac:TaxScheme>
+            </cac:PartyTaxScheme>
+            <cac:PartyLegalEntity>
+                <cbc:RegistrationName>SupplierOfficialName Ltd</cbc:RegistrationName>
+                <cbc:CompanyID>GB983294</cbc:CompanyID>
+            </cac:PartyLegalEntity>
+        </cac:Party>
+    </cac:AccountingSupplierParty>
+    <cac:AccountingCustomerParty>
+        <cac:Party>
+            <cbc:EndpointID schemeID="0002">FR23342</cbc:EndpointID>
+            <cac:PartyIdentification>
+                <cbc:ID schemeID="0002">FR23342</cbc:ID>
+            </cac:PartyIdentification>
+            <cac:PartyName>
+                <cbc:Name>BuyerTradingName AS</cbc:Name>
+            </cac:PartyName>
+            <cac:PostalAddress>
+                <cbc:StreetName>Hovedgatan 32</cbc:StreetName>
+                <cbc:AdditionalStreetName>Po box 878</cbc:AdditionalStreetName>
+                <cbc:CityName>Stockholm</cbc:CityName>
+                <cbc:PostalZone>456 34</cbc:PostalZone>
+                <cac:Country>
+                    <cbc:IdentificationCode>SE</cbc:IdentificationCode>
+                </cac:Country>
+            </cac:PostalAddress>
+            <cac:PartyTaxScheme>
+                <cbc:CompanyID>SE4598375937</cbc:CompanyID>
+                <cac:TaxScheme>
+                    <cbc:ID>VAT</cbc:ID>
+                </cac:TaxScheme>
+            </cac:PartyTaxScheme>
+            <cac:PartyLegalEntity>
+                <cbc:RegistrationName>Buyer Official Name</cbc:RegistrationName>
+                <cbc:CompanyID schemeID="0183">39937423947</cbc:CompanyID>
+            </cac:PartyLegalEntity>
+            <cac:Contact>
+                <cbc:Name>Lisa Johnson</cbc:Name>
+                <cbc:Telephone>23434234</cbc:Telephone>
+                <cbc:ElectronicMail>[email protected]</cbc:ElectronicMail>
+            </cac:Contact>
+        </cac:Party>
+    </cac:AccountingCustomerParty>
+    <cac:Delivery>
+        <cbc:ActualDeliveryDate>2017-11-01</cbc:ActualDeliveryDate>
+        <cac:DeliveryLocation>
+            <cbc:ID schemeID="0088">9483759475923478</cbc:ID>
+            <cac:Address>
+                <cbc:StreetName>Delivery street 2</cbc:StreetName>
+                <cbc:AdditionalStreetName>Building 56</cbc:AdditionalStreetName>
+                <cbc:CityName>Stockholm</cbc:CityName>
+                <cbc:PostalZone>21234</cbc:PostalZone>
+                <cac:Country>
+                    <cbc:IdentificationCode>SE</cbc:IdentificationCode>
+                </cac:Country>
+            </cac:Address>
+        </cac:DeliveryLocation>
+        <cac:DeliveryParty>
+            <cac:PartyName>
+                <cbc:Name>Delivery party Name</cbc:Name>
+            </cac:PartyName>
+        </cac:DeliveryParty>
+    </cac:Delivery>
+    <cac:PaymentMeans>
+        <cbc:PaymentMeansCode name="Credit transfer">30</cbc:PaymentMeansCode>
+        <cbc:PaymentID>Snippet1</cbc:PaymentID>
+        <cac:PayeeFinancialAccount>
+            <cbc:ID>IBAN32423940</cbc:ID>
+            <cbc:Name>AccountName</cbc:Name>
+            <cac:FinancialInstitutionBranch>
+                <cbc:ID>BIC324098</cbc:ID>
+            </cac:FinancialInstitutionBranch>
+        </cac:PayeeFinancialAccount>
+    </cac:PaymentMeans>
+    <cac:PaymentTerms>
+        <cbc:Note>Payment within 10 days, 2% discount</cbc:Note>
+    </cac:PaymentTerms>
+        <cac:AllowanceCharge>
+            <cbc:ChargeIndicator>true</cbc:ChargeIndicator>
+            <cbc:AllowanceChargeReason>Insurance</cbc:AllowanceChargeReason>
+            <cbc:Amount currencyID="EUR">25</cbc:Amount>
+            <cac:TaxCategory>
+                <cbc:ID>S</cbc:ID>
+                <cbc:Percent>25.0</cbc:Percent>
+                <cac:TaxScheme>
+                    <cbc:ID>VAT</cbc:ID>
+                </cac:TaxScheme>
+            </cac:TaxCategory>
+        </cac:AllowanceCharge>
+    <cac:TaxTotal>
+        <cbc:TaxAmount currencyID="EUR">331.25</cbc:TaxAmount>
+        <cac:TaxSubtotal>
+            <cbc:TaxableAmount currencyID="EUR">1325</cbc:TaxableAmount>
+            <cbc:TaxAmount currencyID="EUR">331.25</cbc:TaxAmount>
+            <cac:TaxCategory>
+                <cbc:ID>S</cbc:ID>
+                <cbc:Percent>25.0</cbc:Percent>
+                <cac:TaxScheme>
+                    <cbc:ID>VAT</cbc:ID>
+                </cac:TaxScheme>
+            </cac:TaxCategory>
+        </cac:TaxSubtotal>
+    </cac:TaxTotal>
+    <cac:LegalMonetaryTotal>
+        <cbc:LineExtensionAmount currencyID="EUR">1300</cbc:LineExtensionAmount>
+        <cbc:TaxExclusiveAmount currencyID="EUR">1325</cbc:TaxExclusiveAmount>
+        <cbc:TaxInclusiveAmount currencyID="EUR">1656.25</cbc:TaxInclusiveAmount>
+        <cbc:ChargeTotalAmount currencyID="EUR">25</cbc:ChargeTotalAmount>
+        <cbc:PayableAmount currencyID="EUR">1656.25</cbc:PayableAmount>
+    </cac:LegalMonetaryTotal>
+
+<cac:InvoiceLine>
+        <cbc:ID>1</cbc:ID>
+    <cbc:InvoicedQuantity unitCode="DAY">7</cbc:InvoicedQuantity>
+    <cbc:LineExtensionAmount currencyID= "EUR">2800</cbc:LineExtensionAmount>
+        <cbc:AccountingCost>Konteringsstreng</cbc:AccountingCost>
+       <cac:OrderLineReference>
+            <cbc:LineID>123</cbc:LineID>
+        </cac:OrderLineReference>
+    <cac:Item>
+            <cbc:Description>Description of item</cbc:Description>
+            <cbc:Name>item name</cbc:Name>
+            <cac:StandardItemIdentification>
+                <cbc:ID schemeID="0088">21382183120983</cbc:ID>
+            </cac:StandardItemIdentification>
+            <cac:OriginCountry>
+                <cbc:IdentificationCode>NO</cbc:IdentificationCode>
+            </cac:OriginCountry>
+            <cac:CommodityClassification>
+                <cbc:ItemClassificationCode listID="SRV">09348023</cbc:ItemClassificationCode>
+            </cac:CommodityClassification>
+            <cac:ClassifiedTaxCategory>
+                <cbc:ID>S</cbc:ID>
+                <cbc:Percent>25.0</cbc:Percent>
+                <cac:TaxScheme>
+                    <cbc:ID>VAT</cbc:ID>
+                </cac:TaxScheme>
+            </cac:ClassifiedTaxCategory>
+        </cac:Item>
+    <cac:Price>
+        <cbc:PriceAmount currencyID="EUR">400</cbc:PriceAmount>
+    </cac:Price>
+    </cac:InvoiceLine>
+<cac:InvoiceLine>
+    <cbc:ID>2</cbc:ID>
+    <cbc:InvoicedQuantity unitCode="DAY">-3</cbc:InvoicedQuantity>
+    <cbc:LineExtensionAmount currencyID="EUR">-1500</cbc:LineExtensionAmount>
+    <cac:OrderLineReference>
+        <cbc:LineID>123</cbc:LineID>
+    </cac:OrderLineReference>
+    <cac:Item>
+        <cbc:Description>Description 2</cbc:Description>
+        <cbc:Name>item name 2</cbc:Name>
+        <cac:StandardItemIdentification>
+            <cbc:ID schemeID="0088">21382183120983</cbc:ID>
+        </cac:StandardItemIdentification>
+        <cac:OriginCountry>
+            <cbc:IdentificationCode>NO</cbc:IdentificationCode>
+        </cac:OriginCountry>
+        <cac:CommodityClassification>
+            <cbc:ItemClassificationCode listID="SRV">09348023</cbc:ItemClassificationCode>
+        </cac:CommodityClassification>
+        <cac:ClassifiedTaxCategory>
+            <cbc:ID>S</cbc:ID>
+            <cbc:Percent>25.0</cbc:Percent>
+            <cac:TaxScheme>
+                <cbc:ID>VAT</cbc:ID>
+            </cac:TaxScheme>
+        </cac:ClassifiedTaxCategory>
+    </cac:Item>
+    <cac:Price>
+        <cbc:PriceAmount currencyID="EUR">500</cbc:PriceAmount>
+    </cac:Price>
+</cac:InvoiceLine>
+</Invoice>