-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Building Guide on servers #826
base: master
Are you sure you want to change the base?
Conversation
Oh my, this is going to be tricky...
|
This is not less functional, I've opened this PR just to replace your method with another one that works, and fire events (just like any other mod should fire). This shouldn't have nothing to do with Bukkit/Cauldron/Thermos/whatever, it's just a simple method, it won't change anything in the gameplay, so how am I supposed to make a config option? |
Ah, I was talking about dropping player information, but I misread that part. Though you don't restore snapshot on cancelled event. Also, if it's related to #755, what environments have you tested? |
Since I can't compile the code, I couldn't test, I was about to open an issue about the error but you're here now, so... |
Can't help with Idea (always used Eclipse). Though we are not doing anything special other than subproject for OpenModsLib (which should be supported, since it's standard Gradle feature). |
I just needed a |
It's now working, but I'm having some problems when the event is cancelled: the for loop will skip the protected block, but will still place it (not restoring)... |
Fixed, it's now respecting cancelled events, and working on Singleplayer/Mixed (Forge + Bukkit) servers. With this update, you could also make a release of OpenModsLib (the fix you pushed for /dev/null/ is only in OpenModsLib-1.7.10-0.10-snapshot-465, not in the official release as you fixed it later). |
Please don't ping. I appreciate your work, but unless there is a world-breaking bug, I won't do any more 1.7 releases. Please wait for 1.10 merge. |
No description provided.