[phpstan] Mage_Admin (L7) and re-added composer patches #3660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `$var->disabled` implements `__toString()`, so casting should be okay
- ignored some errors related to missing type declaration - ignored some errors for higher levels, that cant be easily fixed
- change block orders come from "ddev vendor-patches" and should not happen again
github-actions
bot
added
Component: Core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (*)
Idea was to remove some errors in
Mage_Admin.This required to patch
shardj/zf1-future.So it made sense to have all patches back at the repo.
Renamed some vars to match parent methods,
Questions or comments
Patches belong back to the repo.
They belong to a PR, a version, a realese. Having them in another repo makes it more difficult to maintain/review.
Better add them back and archive the patches repo.