Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/LogVisitorSaveByRequest: added initServerData() to populate ServerData on saving visitor_log information #3598

Merged
merged 1 commit into from
Oct 21, 2023

Conversation

eneiasramos
Copy link
Contributor

@eneiasramos eneiasramos commented Oct 16, 2023

bugfix/LogVisitorSaveByRequest: added initServerData() to populate ServerData on saving visitor_log information

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

  1. Fixes OpenMage/magento-lts#<issue_number>

Manual testing scenarios (*)

  1. ...
  2. ...

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)
  • Add yourself to contributors list

@github-actions github-actions bot added the Component: Log Relates to Mage_Log label Oct 16, 2023
@addison74
Copy link
Contributor

This is not a report based on the OM requested standard format. I would like you to provide information about the test environment and the steps to reproduce the error. Otherwise, I will close the report.

@eneiasramos
Copy link
Contributor Author

@addison74 I'll provide you the information my dear 👍

@eneiasramos
Copy link
Contributor Author

eneiasramos commented Oct 17, 2023

image

@addison74 as you can see: only after the fix the URLs started to be recorded corretly in the database ( line 9 and so on ) when changing the URL.

@eneiasramos
Copy link
Contributor Author

@kiatng thank you my dear!

@fballiano fballiano merged commit abdef59 into OpenMage:main Oct 21, 2023
17 checks passed
@eneiasramos
Copy link
Contributor Author

@fballiano thank you my dear!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Log Relates to Mage_Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants