DONT MERGE Master+ipynb #414
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, the push should be done automatically for each push on master, right? Or what is this PR for? |
|
We don't push the ipynb's back to Master. This was just a lazy way to test the GHA activation. I tried to move forward with #320 but using conda in the action spins forever: https://github.com/OpenMS/pyopenms-docs/actions/runs/6719647447/job/18261670898?pr=320 |
github-actions
bot
force-pushed
the
master+ipynb
branch
2 times, most recently
from
9b1b43a
to
d19d8e5
Compare
|
I think we should use (micro)mamba instead of conda these days. Might help with runtime. |
|
ah ok came to say same thing... we don't usually push back the notebooks into master (to keep it clean). |
|
Something I did realize is that the way we do it now means past version of
the notebooks get wiped every time master+ipynb gets updated.
…On Thu, Nov 2, 2023 at 9:39 AM Timo Sachsenberg ***@***.***> wrote:
ah ok came to say same thing... we don't usually push back the notebooks
into master (to keep it clean).
—
Reply to this email directly, view it on GitHub
<#414 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABD3C6VXSAFWNL2S44NFDDYCNL4DAVCNFSM6AAAAAA6ZL6O7OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQGI4TCOJZGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Yep. That's mainly why this branch should never be touched manually 😅 |
github-actions
bot
force-pushed
the
master+ipynb
branch
from
d19d8e5
to
98322d5
Compare
github-actions
bot
force-pushed
the
master+ipynb
branch
2 times, most recently
from
05ff659
to
07bb49d
Compare
github-actions
bot
force-pushed
the
master+ipynb
branch
from
07bb49d
to
61fd013
Compare
github-actions
bot
force-pushed
the
master+ipynb
branch
from
61fd013
to
b4c88e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.