-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link fixin #252
Link fixin #252
Conversation
Should I be worried about the failing build_test? |
It seems we did not have a working pyopenms build in 30? days, so there is not artifact anymore. |
Kudos, SonarCloud Quality Gate passed! |
there are autofixes available: https://github.com/OpenMS/pyopenms-extra/pull/252/checks?check_run_id=4879571790 |
Kudos, SonarCloud Quality Gate passed! |
If the links work like this I think we can move forward here |
Lint fails with |
This is an error in the action. See their GitHub repo. Should be a comment from me as well. There is a workaround using a fork from someone. But maybe the action was updated by now. Please check. |
@timosachsenberg when fixing the API docs I saw quite some warnings like XYZ.rst never referenced anywhere. Including hyper score. Can you check this? Just build yourself locally and you will see. Indeed I cannot find hyperscore except in the search. |
Unfortunately we have a lot of warning now from the API docs. We should check if we can filter them somehow. |
Why are these not referenced? What is missing? |
docs/source/wrap_classes.rst
Outdated
See the next section for a SimpleExample_ and a more AdvancedExample_ of a wrapped class with several functions. | ||
|
||
See the next section for a `simple example <#Simple-Example>`_ and a more AdvancedExample_ of a wrapped class with several functions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we have the same style for both links?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup. fixed
can you revive this so we can move it over the finish line? |
hscore = HyperScore() | ||
fragment_mass_tolerance = 5.0 | ||
is_tol_in_ppm = True | ||
result = hscore.compute(fragment_mass_tolerance, is_tol_in_ppm, spectrum_of_interest, thspec) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[blacken-docs] reported by reviewdog 🐶
result = hscore.compute(fragment_mass_tolerance, is_tol_in_ppm, spectrum_of_interest, thspec) | |
result = hscore.compute( | |
fragment_mass_tolerance, is_tol_in_ppm, spectrum_of_interest, thspec | |
) |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
cool! thanks |
Fixed a bunch of stale links, added files for future nase tutorial