Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] example for enums in namespaces #131

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hroest
Copy link
Collaborator

@hroest hroest commented Mar 24, 2022

Draft proposal on how to handle enums in different namespaces

@hroest
Copy link
Collaborator Author

hroest commented Mar 25, 2022

@jpfeuffer it seems like now your test with regards to type safety doesnt work any more -- I can revert this and add the namespace-enum test separately, what do you think?

@jpfeuffer
Copy link
Contributor

Yes separate tests would work great I think. Thank you!

@timosachsenberg
Copy link
Contributor

@jpfeuffer is this ready to merge?

@jpfeuffer
Copy link
Contributor

This precedes CI and needs to be updated to run the tests.

And looking at our comments, it sounds like CI might fail.

@jpfeuffer
Copy link
Contributor

@timosachsenberg Now you can see the failures. Once they are fixed, we can merge.

@timosachsenberg
Copy link
Contributor

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants