Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address deprecated SonarCloud build-wrapper-dump #60

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

velomatt
Copy link
Contributor

SonarCloud has announced deprecated build-wrapper-dump.json https://docs.sonarsource.com/sonarcloud/deprecations-and-removals/

This change has not been announced for SonarQube, so we need to support build-wrapper-dump.json for SonarQube
and the new compile_commands.json for SonarCloud.

Changes made:

  • removed sonar.cfamily.build-wrapper-output from sonar-project.properties file
  • change sed command to replace CODEBUILD_SRC_DIR to compile_commands.json
  • pass sonar.cfamily.compile-commands in sonar-scanner.yml

No change is needed for gitlab-ci because we are already passing sonar.cfamily.build-wrapper-output during sonar-scanner stage

SonarCloud has announced deprecated build-wrapper-dump.json
https://docs.sonarsource.com/sonarcloud/deprecations-and-removals/

This change has not been announced for SonarQube, so we need to support
build-wrapper-dump.json for SonarQube
and the new compile_commands.json for SonarCloud.

Changes made:
- removed sonar.cfamily.build-wrapper-output from
sonar-project.properties file
- change sed command to replace CODEBUILD_SRC_DIR to
compile_commands.json
- pass sonar.cfamily.compile-commands in sonar-scanner.yml

No change is needed for gitlab-ci because we are already passing
sonar.cfamily.build-wrapper-output during sonar-scanner stage
@velomatt velomatt requested a review from a team as a code owner June 20, 2024 22:59
Copy link

Copy link

@snubatreus snubatreus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@velomatt velomatt merged commit 09a28e4 into master Jun 21, 2024
6 checks passed
@velomatt velomatt deleted the Address-deprecated-SonarCloud-build-wrapper-dump branch June 21, 2024 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants