Adding gen2 s3 benchmark changes #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velomatt
requested changes
Nov 2, 2023
There was a problem hiding this comment.
Need the following changes:
- delete pre-built s3-benchmark
- modify s3-benchmark readme to explain how to build (clone/build dss-sdk, install yum deps, etc) - while you're at it, I just noticed there are internal URLs mentioned in that readme that need to be removed...
|
@velomatt README files are updated and removal of binary is done in a separate repository as part of MINIO build script OpenMPDK/dss-minio#16 |
|
Kudos, SonarCloud Quality Gate passed!
|
velomatt
approved these changes
Nov 8, 2023
nsarras
deleted the
77-gitlab-pipeline-s3-benchmark-build-and-repackage-s3-benchmark-binary-as-part-of-gitlab-pipeline
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.