added previous_tags setting #306
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xlcrr
requested changes
Aug 7, 2021
| @@ -543,6 +576,7 @@ export default { | |||
| */ | |||
| async submit () | |||
| { | |||
| // this.previousTags = (this.$store.state.litter.tags[this.id] || {}); | |||
There was a problem hiding this comment.
Do we need this or not? If its not needed it can be deleted
There was a problem hiding this comment.
Yes we do. When you click the submit button, then it stores the tags you used.
There was a problem hiding this comment.
I got rid of it. My bad.
xlcrr
requested changes
Aug 16, 2021
| /* Whether to save the tags from a previous image */ | ||
| $user->previous_tags = $request->previous_tags; | ||
|
|
||
| $user->save(); |
There was a problem hiding this comment.
We should also return a response and handle it
return [
'success' => true
];.then(response => {
console.log('my_action', response);
if (response.data.success)
{
// Handle success eg show successful event notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR creates a setting for users to allow previous tags used in an image to appear on the current one.