Add API server NetworkPolicy to support a potential deny all egress #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturdzm
reviewed
Apr 24, 2024
| // If allowed, add an Egress rule to access the API server. | ||
| // Otherwise, if the OpenShift DNS or K8s CoreDNS Egress rule does not provide permissive cluster-wide access | ||
| // and the K8s API server could not be found, use a permissive cluster-wide Egress rule. | ||
| if apiServerEndpoints, err := r.getEndpoints("kubernetes", "default"); err == nil { |
There was a problem hiding this comment.
I think, if we can't get DNS info and using permissive rule we can skip this step as optimization. Without DNS it won't be able to resolve hostname in the pod, even if it allows kuberneres service IPs. And most likely if we codun't get DNS svc info we also will fail on this one
There was a problem hiding this comment.
I moved the usingPermissiveRule flag out of the else if block to also exit early when trying the API server Endpoint lookup if DNS check is using permissive rule.
also, add nil check to dnsEndpoints.Subsets and GetEndpointPortByName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.