Final issue 109 #113
Merged
Final issue 109 #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge staging to prod - updated to use quit-ctrlc (#110)
gkwan-ibm
requested changes
Oct 25, 2023
There was a problem hiding this comment.
TestData.java
- license year should be
2017, 2023 - the changes are so complicated. See https://github.com/OpenLiberty/guide-cors/blob/gkwan-ibm-fix-1/finish/src/test/java/it/io/openliberty/guides/cors/TestData.java
- use final
- remove public
- shorten the variable names
gkwan-ibm
approved these changes
Oct 27, 2023
gkwan-ibm
added a commit
that referenced
this pull request
Nov 14, 2023
Merge staging to prod - Final issue 109 (#113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressed issue: #109