Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating guide’s content to use the Liberty AKS portal for creating cluster, resource group, and container #129

Open
wants to merge 44 commits into
base: staging
Choose a base branch
from

Conversation

Ruilin-Ma
Copy link

@Ruilin-Ma Ruilin-Ma commented Jul 22, 2024

issue #80

README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
Ruilin-Ma and others added 2 commits August 6, 2024 11:55
* Bump org.apache.maven.plugins:maven-failsafe-plugin in /start

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump org.apache.maven.plugins:maven-surefire-plugin in /start

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump org.apache.maven.plugins:maven-failsafe-plugin in /finish

Bumps [org.apache.maven.plugins:maven-failsafe-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-failsafe-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Bump org.apache.maven.plugins:maven-surefire-plugin in /finish

Bumps [org.apache.maven.plugins:maven-surefire-plugin](https://github.com/apache/maven-surefire) from 3.3.0 to 3.3.1.
- [Release notes](https://github.com/apache/maven-surefire/releases)
- [Commits](apache/maven-surefire@surefire-3.3.0...surefire-3.3.1)

---
updated-dependencies:
- dependency-name: org.apache.maven.plugins:maven-surefire-plugin
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
README.adoc Show resolved Hide resolved
README.adoc Outdated Show resolved Hide resolved
@gkwan-ibm
Copy link
Member

  • search the role requirement from azure doc for users to create resource group, then add those prereq in the content

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Aug 9, 2024

  • It is better to simplify the content of the Provision deployment foundation with Liberty on AKS section. The guide has no need to describe in detail like as a doc. Users only need to provide info in the Basics pane and leave other panes as default. After filling up the Basics pane, they can click the Review+Create button to create the resources group and cluster. Let the guide to demonstrate how simple to create them. Just mention that if interest to know more configuration, they can visit the other panes.
  • in the Access the created cluster section, is there a command, e.g. az aks show, to get the [cluster-name] instead of from the GUI?
  • clusterXXXXXX in the output can be replaced by a makeup string, e.g. cluster1234d5
  • in the Logging into the container registry subsection, can add a command to get the [registry-name]? In this case, screenshot can be kept.

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Aug 13, 2024

  • remove
    • Please note, the plan also supports to use an existing resource group while the group is required to be empty.

  • Before this statement "To push Docker images to your registry, you must log in to your Azure Container Registry by using the Azure CLI.", need to tell users which value is the [registry-name], e.g. acr1234d5 under the NAME column from the output

@shin19991207
Copy link

shin19991207 commented Sep 24, 2024

Address Laura's comments:

  • Can you remove the bold highlighting on the names in the What you’ll learn and the Additional prereqs sections, pls? It’s not necessary.
  • “a cost may associated” > “a cost may be associated”
  • “Azure Subscription:” should be “Azure subscription:“.
  • “IBM WebSphere Liberty and Open Liberty on AKS:” should be “IBM WebSphere Liberty and Open Liberty on AKS plan:” But also remove all the bold highlighting here.
  • “Provision deployment foundation with Liberty on AKS” and others sections need to have some kind of introduction for the section before the first sub-heading (see old Azure guide for example, though it too doesn’t always do it but should).
  • Not sure about the heading “Provision deployment foundation with Liberty on AKS” - could do with something more meaningful I think.

@gkwan-ibm
Copy link
Member

gkwan-ibm commented Oct 4, 2024

  • Somewhere need to mention the plan/provisioning of the cluster also provides the OL operator.
  • test on Win
  • on Mac, the az aks install-cli command need to use sudo az aks install-cli. Linix may need sudo too. Surely it may different than Win.
  • at the end of the Setting up ACR and Kubernetes cluster on AKS subsection, tell users how to know the deployment is completed, e.g. When the deployment is completed, a Your deployment is complete message is shown.
  • at the end of the Connecting the AKS cluster to Kubernetes subsection, update the output v1.29.7 to v1.29.8

@shin19991207
Copy link

  • on Mac, the az aks install-cli command need to use sudo az aks install-cli. Linix may need sudo too. Surely it may different than Win.
  • Sudo for Windows requires Windows 11 Insider Preview Build 26052 or higher
  • Runas
    • The runas command in Windows requires running with a full path, i.e. runas /user:Administrator "C:\path\to\az.cmd aks install-cli"
    • Every Windows installation has a built-in Administrator account. However, it is not always enabled by default.
    • Alternatively, instead of using runas, you can open Command Prompt or PowerShell as Administrator (right-click > "Run as administrator") and then run the command(s)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants