Compose parameters for binary scanner from umbrella version numbers in build file #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…constants. Signed-off-by: Paul Gooderham <[email protected]>
Signed-off-by: Paul Gooderham <[email protected]>
kathrynkodama
approved these changes
Jun 27, 2022
TrevCraw
reviewed
Jun 27, 2022
src/main/groovy/io/openliberty/tools/gradle/tasks/GenerateFeaturesTask.groovy
Outdated
Show resolved
Hide resolved
Signed-off-by: Paul Gooderham <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the facility added in BinaryScannerUtil to create a version number parameter from the value in the build.gradle build file.
No tests are added due to issues changing the build file in dev mode in JUnit. Similar code in ci.maven tests the message generated by BinaryScannerUtil. Related to #708