Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify behavior for include directory to match Liberty #426

Merged
merged 6 commits into from
Oct 27, 2023
Merged

Modify behavior for include directory to match Liberty #426

merged 6 commits into from
Oct 27, 2023

Conversation

evie-lau
Copy link
Member

@evie-lau evie-lau commented Oct 26, 2023 •
edited
Loading

Follow-up to #425
Match Liberty behavior where directory has to end in File.separator

Note: Both Liberty and our test code convert Windows \ into /, so all the logic uses /

Note implemented behavior in #426 (comment)

@evie-lau evie-lau merged commit d5b02e9 into OpenLiberty:main Oct 27, 2023
8 checks passed
@evie-lau evie-lau deleted the includeDirFixes branch October 27, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherylking cherylking cherylking approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evie-lau @cherylking