Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAM-64: init of organizations #80

Merged
merged 12 commits into from
May 23, 2024
Merged

OAM-64: init of organizations #80

merged 12 commits into from
May 23, 2024

Conversation

olewandowski1
Copy link
Contributor

@olewandowski1 olewandowski1 commented Apr 25, 2024 •
edited
Loading

OAM-64

Changes:

  • Organization page. Possibility to add/edit/disable organization.
  • Valid destinations/valid sources cannot be connected to organization if disabled.
  • Add proper indicator to the list of organizations. If disabled, there is an '[DISABLED]' label.
    image

@olewandowski1 olewandowski1 changed the title OAM-64: init of suppliers OAM-64: init of organizations May 10, 2024
@olewandowski1 olewandowski1 marked this pull request as ready for review May 22, 2024 08:23
@olewandowski1 olewandowski1 requested a review from DominikNoga May 22, 2024 08:23
DominikNoga
DominikNoga reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@DominikNoga DominikNoga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is generally ok, i just found a space for improvement in the binding of fixed messages in html files

src/admin-valid-source-add/valid-source-add.html Outdated Show resolved Hide resolved
src/admin-valid-destination-add/valid-destination-add.html Outdated Show resolved Hide resolved
src/organization-add/organization-add.html Outdated Show resolved Hide resolved
src/organization-edit/organization-edit.html Outdated Show resolved Hide resolved
@olewandowski1 olewandowski1 requested a review from DominikNoga May 23, 2024 06:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@DominikNoga DominikNoga merged commit c818440 into master May 23, 2024
2 checks passed
@olewandowski1 olewandowski1 deleted the feature/OAM-64 branch May 23, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikNoga DominikNoga DominikNoga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@olewandowski1 @DominikNoga