OAM-55: optimize login - improve local storage operations

src/stock-adjustment-creation/source-destination.service.js

@@ -94,17 +94,21 @@
         }
 
         function cacheSources(sources, facilityId) {
-            sources.forEach(function(source) {
+            var sourcesToStore = sources.map(function(source) {
                 source.facilityId = facilityId;
-                offlineSources.put(source);
+                return source;
             });
+
+            offlineSources.putAll(sourcesToStore);
         }
 
         function cacheDestinations(destinations, facilityId) {
-            destinations.forEach(function(destination) {
+            var destinationsToStore = destinations.map(function(destination) {
                 destination.facilityId = facilityId;
-                offlineDestinations.put(destination);
+                return destination;
             });
+
+            offlineDestinations.putAll(destinationsToStore);
         }
 
         function clearSourcesCache() {

src/stock-adjustment-creation/source-destination.service.spec.js

@@ -18,7 +18,7 @@ describe('sourceDestinationService', function() {
 
     beforeEach(function() {
         this.offlineService = jasmine.createSpyObj('offlineService', ['isOffline', 'checkConnection']);
-        this.storage = jasmine.createSpyObj('offlineStorage', ['put', 'search', 'getAll']);
+        this.storage = jasmine.createSpyObj('offlineStorage', ['put', 'putAll', 'search', 'getAll']);
 
         var storage = this.storage,
             offlineService = this.offlineService;

src/stock-reason/stock-reasons.factory.js

@@ -146,19 +146,22 @@
         function getReasons(programIds, facilityType, reasonType) {
             return $q.resolve(getReasonsPromise(programIds, facilityType, reasonType)
                 .then(function(reasonAssignments) {
-                    return reasonAssignments
+                    var filteredReasons = reasonAssignments
                         .filter(function(reasonAssignment) {
                             return !reasonAssignment.hidden;
                         })
                         .reduce(function(result, reasonAssignment) {
                             if (result.indexOf(reasonAssignment.reason) < 0) {
                                 result.push(reasonAssignment.reason);
                             }
-                            if (!offlineService.isOffline()) {
-                                cacheReasons(reasonAssignment, programIds, facilityType);
-                            }
                             return result;
                         }, []);
+
+                    if (!offlineService.isOffline()) {
+                        cacheReasons(filteredReasons, programIds, facilityType);
+                    }
+
+                    return filteredReasons;
                 }));
         }
 
@@ -183,18 +186,20 @@
             });
         }
 
-        function cacheReasons(reasonAssignment, programIds, facilityType) {
-            var reason = angular.copy(reasonAssignment.reason);
-            var reasonToCache = {
-                id: reasonAssignment.id,
-                programId: programIds,
-                facilityType: facilityType,
-                reasonType: reason.reasonType,
-                reason: reason,
-                hidden: reasonAssignment.hidden
-            };
+        function cacheReasons(filteredReasons, programIds, facilityType) {
+            var reasonsToCache = filteredReasons.map(function(reason) {
+                var reasonCopy = angular.copy(reason);
+                return {
+                    id: reason.id,
+                    programId: programIds,
+                    facilityType: facilityType,
+                    reasonType: reasonCopy.reasonType,
+                    reason: reasonCopy,
+                    hidden: reason.hidden
+                };
+            });
 
-            offlineReasons.put(reasonToCache);
+            offlineReasons.putAll(reasonsToCache);
         }
 
         function clearReasonsCache() {

src/stock-reason/stock-reasons.factory.spec.js

@@ -20,7 +20,7 @@ describe('stockReasonsFactory', function() {
     beforeEach(function() {
         module('stock-reasons-modal', function($provide) {
             validReasonResourceMock = jasmine.createSpyObj('validReasonResource', ['query']);
-            reasonsStorage = jasmine.createSpyObj('offlineReasons', ['search', 'getAll', 'put']);
+            reasonsStorage = jasmine.createSpyObj('offlineReasons', ['search', 'getAll', 'putAll', 'put']);
             reasonsStorage.getAll.andReturn([false]);
 
             $provide.factory('ValidReasonResource', function() {