Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make value generation locale independent. #53

Closed
wants to merge 1 commit into from
Closed

Conversation

yevgenp
Copy link

@yevgenp yevgenp commented Jun 19, 2024

Copy link

@@ -111,7 +119,7 @@ public void testGenerateNativeWithGetUsing() throws ClassNotFoundException, Ille
Class<?> aClass = CACHED_COMPILER.loadFromJava(
BytecodeGen.getClassLoader(JavaBeanInterfaceGetUsing.class),
JavaBeanInterfaceGetUsing.class.getName() + "$$Native", actual);
JavaBeanInterfaceGetUsing jbi = (JavaBeanInterfaceGetUsing) aClass.asSubclass(JavaBeanInterfaceGetUsing.class).getDeclaredConstructor().newInstance();
JavaBeanInterfaceGetUsing jbi = aClass.asSubclass(JavaBeanInterfaceGetUsing.class).getDeclaredConstructor().newInstance();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

Copy link
Contributor

@JerryShea JerryShea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved by me. I've asked the original bug reporter if they can test too, so suggest we give them a day or two to respond

@tgd tgd closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants