-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add more params to dapr pubsub subscription #58
base: main
Are you sure you want to change the base?
add more params to dapr pubsub subscription #58
Conversation
|
@@ -331,6 +332,12 @@ type TracingProvider struct { | |||
OapServer string `json:"oapServer" yaml:"oapServer"` | |||
} | |||
|
|||
type PubSubRoutingRule struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not define the router
, match
, and priority
directly into the input
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I think it is more clear to group router
, match
, priority
to the one struct PubSubRoutingRule
, other than put them directly into the input
considering every prop. Uri
, ComponentName
, ComponentType
, Metadata
maybe different for different trigger,
of input in function context
type Input struct {
Uri string `json:"uri,omitempty"`
ComponentName string `json:"componentName"`
ComponentType string `json:"componentType"`
Metadata map[string]string `json:"metadata,omitempty"`
}
@tpiperatgod @wrongerror hi , any suggestions on this pr? |
See my comments in OpenFunction/OpenFunction#332 |
fixed it . please have a look. |
Please make sure this pr does not conflict with #66, they both set the |
Looks like still not fixed OpenFunction/OpenFunction#332 (comment): |
fix issue: OpenFunction/OpenFunction#329