Better test #16

chaiwa-berian · 2021-01-19T09:38:12Z

The tests for get and post pass but the tests for patch,put, and del fail with the error TypeError: Cannot convert undefined or null to object. @stuartc Kindly review and advise. After the last three pass, this PR should fix #13 .

…onvert undefined or null to object, for #13

stuartc · 2021-01-19T11:42:28Z

@chaiwa-berian I think I found the issue/s:

composeNextState expects there to be a references key in the state, which only exists if you call the operations with execute(...) (that adds a references key to the state before calling the operations).
The response body you are sending in the nock reply has the key body in it. But there is also some strange (probably always been like this) behaviour around tryJson and how the generic req function handles responses...
I'm going to leave that stuff alone since I think between us stubbing the response with nock and us about to move away from request I don't want to spend more time on that..

So yeah long story short the tests are passing now.

stuartc · 2021-01-19T11:43:49Z

test/index.js

  });
 });

 describe('delete', () => {
  before(() => {
    testServer.delete('/api/fake-del-items/6').reply(204, function (url, body) {
-      return {};
+      return JSON.stringify({});


Nothing significant about this, but it does test that the body is turned back into an object via tryJson.

stuartc and others added 7 commits January 15, 2021 14:42

Update deps and babel config

470e8d7

Outline for better tests

f8a69ce

Test Node 12 and 14

9feb5bd

Add all tests, 6 additional passing, 1 Coookie test failing, for #13

d9a2e0b

pass keepCookie as param to get(...)

52f30b0

Add tests for get and post, for #13

c2a1e16

get,post tests work. put,patch,del return error : TypeError: Cannot c…

94f3582

…onvert undefined or null to object, for #13

stuartc self-assigned this Jan 19, 2021

Fix tests

094bcc2

stuartc reviewed Jan 19, 2021

View reviewed changes

stuartc merged commit 6392340 into master Jan 19, 2021

stuartc deleted the better-test branch January 19, 2021 12:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better test #16

Better test #16

chaiwa-berian commented Jan 19, 2021

stuartc commented Jan 19, 2021

stuartc Jan 19, 2021

Better test #16

Better test #16

Conversation

chaiwa-berian commented Jan 19, 2021

stuartc commented Jan 19, 2021

stuartc Jan 19, 2021

Choose a reason for hiding this comment