Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub sync important considerations #566

Merged
merged 4 commits into from
Oct 18, 2024
Merged

Conversation

mtuchi
Copy link
Contributor

@mtuchi mtuchi commented Aug 30, 2024

Description

I have update the GitHub sync guide to include important considerations especially with job file path support

Ref #539

@mtuchi mtuchi linked an issue Aug 30, 2024 that may be closed by this pull request
@mtuchi mtuchi changed the title add important considerations GitHub sync important considerations Aug 30, 2024
@aleksa-krolls
Copy link
Member

this looks good to me and helpful. @christad92 is this all still accurate? If yes, can we merge?

@christad92
Copy link
Contributor

this looks good to me and helpful. @christad92 is this all still accurate? If yes, can we merge?

Thanks. taking a look at now.

@aleksa-krolls
Copy link
Member

hey @christad92 can we merge this now?

@christad92
Copy link
Contributor

I have some pending fixes I want to make tomorrow. I'll let you know as when I'm done with those.

Copy link
Contributor

@christad92 christad92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mtuchi

@christad92
Copy link
Contributor

hey @christad92 can we merge this now?

Yes! I am good with this now.

Thanks

@aleksa-krolls aleksa-krolls merged commit 9091cfb into main Oct 18, 2024
1 check passed
@aleksa-krolls aleksa-krolls deleted the 539-filepaths-github-sync branch October 18, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Docs on filePaths and Github sync
3 participants