Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify mappings example in troubleshooting.md #556

Merged
merged 2 commits into from
Sep 13, 2024
Merged

Clarify mappings example in troubleshooting.md #556

merged 2 commits into from
Sep 13, 2024

Conversation

DrCord
Copy link
Contributor

@DrCord DrCord commented Aug 26, 2024

No description provided.

josephjclark
josephjclark requested changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@josephjclark josephjclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not so sure on this one? I see the problem but there are no two "For examples" in this paragraph.

Maybe if we tweak (mostly remove) the sentence before, it'll flow a bit more clearly

I will come back and look at this next week

@josephjclark
Copy link
Contributor

@DrCord Thanks!

@josephjclark josephjclark merged commit dcbdfdb into OpenFn:main Sep 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josephjclark josephjclark josephjclark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Documentation
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DrCord @josephjclark