Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new docs structure with stubs for Lightning version of docs #372

Merged
merged 13 commits into from
Nov 28, 2023
Merged

new docs structure with stubs for Lightning version of docs #372

merged 13 commits into from
Nov 28, 2023

Conversation

aleksa-krolls
Copy link
Member

Lightning docs: Added stubs for new docs pages, and removed old pages per the agreed Information Architecture

@aleksa-krolls
Copy link
Member Author

aleksa-krolls commented Nov 27, 2023 •
edited
Loading

@taylordowns2000 this is wip, but made some good progress. Does this look okay to merge to main so that my team can continue to contributing to this as well? Thoughts?
(My intention was to only update the Lightning version of the docs, not Platform v1.)

@aleksa-krolls
Copy link
Member Author

@taylordowns2000 I can fix the broken links, but can you lmk if everything else looks okay/that I approached this in the right way? ty!

taylordowns2000
taylordowns2000 requested changes Nov 28, 2023
View reviewed changes
Copy link
Member

@taylordowns2000 taylordowns2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has a couple of broken links that need to be resolved (see image) but is otherwise good to go!

image

@aleksa-krolls
Copy link
Member Author

@taylordowns2000 I've fixed all broken links, but now it keeps throwing errors on the style-guide page related to some of the md components in there. This content is not new, and I'm not able to replicate this build error locally... so only see it when the deployment checks run. Can you please check it out and help me troubleshoot?
https://github.com/OpenFn/docs/actions/runs/7019236130/job/19096240604?pr=372
Screen Shot 2023-11-28 at 3 19 27 PM

@taylordowns2000 taylordowns2000 merged commit c51edd3 into main Nov 28, 2023
1 check passed
@taylordowns2000 taylordowns2000 deleted the new-docs-architecture branch November 28, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylordowns2000 taylordowns2000 taylordowns2000 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksa-krolls @taylordowns2000