Nikki lacrima patch particles #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with 8.3 features branch
Check that LockGuard command is intended for the collar wearer
Medea-Destiny
approved these changes
Sep 5, 2024
|
Addresses the filtering point I raised in #1087, and includes the typo fix for commenting out of the debug message. Closing #1087 as this supersedes and it's @NikkiLacrima's baby. Thanks for the quick response Nikki! |
Closed
SilkieSabra
merged commit de3a44d
into
OpenCollarTeam:8.3_Features-branch
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LockGuard handler in oc_particles should check that the LG message is actually intended for the wearer, follow up on #1087