-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor and Add Component Tests #195
Conversation
🚀 The |
Linter Issue ReportDuring the code review, a list issues were found. These issues could affect the code quality, maintainability, and consistency. Below is the detailed Linter issue report: component/wireset.goLint Issue: undefined: TagComponent
Please make the suggested changes to improve the code quality. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The TipsCodeReview Commands (invoked as MR or PR comments)
CodeReview Discussion ChatThere are 2 ways to chat with Starship CodeReview:
Note: Be mindful of the bot's finite context window. CodeReview Documentation and Community
|
* refactor and add some component tests * remove debug print
This PR adding unit tests for the repo/user/space/model/accounting components. Some tests are currently failed and commented out because they were written based on the CSGHub enterprise/cloud version of the code. There are differences between the open-source version (this repository) and the enterprise/cloud version, which is causing these tests to fail.
We are in the process of refactoring the entire project to improve support for different versions, making it easier to develop, test, and build. Since significant changes are expected during this refactoring, the best course of action for now is to comment out the failing tests and revisit them once the refactor is complete.
Other refactors in this PR include: