Fix last commit API with empty repository #170
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue OpenCSGs/csghub#768
last_commit
API in an empty repository will case a panic.MR Summary:
The summary is added by @codegpt.
The Merge Request addresses a bug related to the
last_commit
API call on an empty repository, which previously caused a panic. The fix involves ensuring the API handles empty repositories gracefully without crashing. Key updates include:GetRepoLastCommit
function incommit.go
to check if the response and the commit object are not nil before proceeding.SDKModelInfo
function inmodel.go
to handle cases where the last commit might be nil, preventing potential null pointer exceptions by introducing a check before assigning the commit ID.