Fix tests for enterprise #1719
Merged
Fix tests for enterprise #1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1719 +/- ##
=======================================
Coverage 76.31% 76.31%
=======================================
Files 603 603
Lines 46101 46101
Branches 844 844
=======================================
Hits 35184 35184
Misses 10821 10821
Partials 96 96
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
jmthomas
approved these changes
Nov 21, 2024
| await page | ||
| .locator('#openc3-menu >> text=Script Runner') | ||
| .click({ force: true }) | ||
| await page.keyboard.press('Escape') |
| @@ -47,6 +47,7 @@ test.describe('CmdTlmServer', () => { | |||
| test.use({ | |||
| toolPath: '/tools/cmdtlmserver', | |||
| toolName: 'CmdTlmServer', | |||
| storageState: 'adminStorageState.json', | |||
There was a problem hiding this comment.
I think this was the key missing piece for enterprise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly small changes, plus fixing the app wrapper in enterprise itself