Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RawDialog behavior #1718

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Fix RawDialog behavior #1718

merged 7 commits into from
Nov 22, 2024

Conversation

ryan-pratt
Copy link
Contributor

This fixes the following issues with the raw dialog on cmdtlmserver:

  • z-indexes underneath the sticky header of the log messages table
  • resizing allows you to shrink it too small and hide the toolbar

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.32%. Comparing base (288b67a) to head (60973a3).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
...-cmdtlmserver/src/tools/CmdTlmServer/RawDialog.vue 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
+ Coverage   76.31%   76.32%   +0.01%     
==========================================
  Files         603      603              
  Lines       46101    46104       +3     
  Branches      844      844              
==========================================
+ Hits        35184    35191       +7     
+ Misses      10821    10816       -5     
- Partials       96       97       +1     
Flag Coverage Δ
frontend 56.39% <66.66%> (+0.07%) ⬆️
python 83.97% <ø> (+<0.01%) ⬆️
ruby-api 48.70% <ø> (ø)
ruby-backend 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ryan-pratt ryan-pratt marked this pull request as ready for review November 21, 2024 17:23
Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's something weird with the right edge. It's like there's two separate scrollbars but there's not:
Screenshot 2024-11-21 at 2 16 25 PM

max-height: 85vh;
min-width: 800px;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this needs to be 830 ... try opening the INST IMAGE packet with all the ascii

Copy link

sonarcloud bot commented Nov 22, 2024

@ryan-pratt ryan-pratt merged commit cf8e782 into main Nov 22, 2024
27 checks passed
@ryan-pratt ryan-pratt deleted the bug/raw-dialog branch November 22, 2024 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants