Critical Commanding Support For Enterprise #1627
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1627 +/- ##
==========================================
- Coverage 76.77% 76.47% -0.31%
==========================================
Files 614 618 +4
Lines 46403 46762 +359
Branches 827 829 +2
==========================================
+ Hits 35628 35760 +132
- Misses 10683 10909 +226
- Partials 92 93 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ryanmelt
changed the title
|
|
||
| offsets = nil | ||
| offsets = [start_offset] if start_offset | ||
| offsets = [start_offset, "$"] if start_offset |
There was a problem hiding this comment.
What does the "$" do? comment?
| @@ -252,6 +276,21 @@ def deploy_scopecleanup_microservice(gem_path, variables, parent) | |||
| Logger.info "Configured microservice #{microservice_name}" | |||
| end | |||
|
|
|||
| def deploy_critical_cmd_microservice(gem_path, variables, parent) | |||
| microservice_name = "#{@scope}__CRITICALCMD__#{@scope}" | |||
There was a problem hiding this comment.
Need a corresponding model.destroy in undeploy
| # or say Yes and send the command. Thus we don't care about the return value. | ||
| prompt_for_hazardous(e.target_name, e.cmd_name, e.hazardous_description) | ||
| target_name, cmd_name, cmd_params = $api_server.method_missing(cmd_no_hazardous, *args, timeout: timeout, log_message: log_message, validate: validate, scope: scope, token: token) | ||
| if log_message.nil? or log_message |
There was a problem hiding this comment.
This is a weird check but I think it means log_message must be explicitly false for us to NOT call _log_cmd
| <v-btn | ||
| type="submit" | ||
| @click.prevent="reject" | ||
| class="mx-2" |
There was a problem hiding this comment.
Add outlined to match existing dialogs ... it's just an attribute not a class
There was a problem hiding this comment.
I had this originally, but it didn't respect disabled (looked exactly the same), so I dropped it.
|
I noticed when sending a command in Command Sender you initially get the status as: Even after approving the command the status doesn't change. It should say the command was sent. Not sure if you have to listen to the topic to know when this approval happens or what but we need the status to be accurate. |
|
Updated confirmation dialog that handles errors: |
|
No description provided.