Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cli script wait #1501

Merged
merged 26 commits into from
Sep 18, 2024
Merged

Cli script wait #1501

merged 26 commits into from
Sep 18, 2024

Conversation

JL-Brothers
Copy link
Contributor

@JL-Brothers JL-Brothers commented Aug 28, 2024

Allow starting OpenC3 scripts from the terminal cli with a settable period to wait for status updates to flow back to the terminal.
closes #1213

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 76.78%. Comparing base (1e4ad3a) to head (77316ed).
Report is 71 commits behind head on main.

Files with missing lines Patch % Lines
...mos-script-runner-api/app/models/running_script.rb 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
- Coverage   76.78%   76.78%   -0.01%     
==========================================
  Files         609      609              
  Lines       45938    45940       +2     
  Branches      798      798              
==========================================
+ Hits        35272    35273       +1     
- Misses      10578    10580       +2     
+ Partials       88       87       -1     
Flag Coverage Δ
frontend 55.96% <ø> (ø)
python 84.61% <ø> (+<0.01%) ⬆️
ruby-api 48.97% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Show resolved Hide resolved
openc3/bin/openc3cli Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
@JL-Brothers JL-Brothers marked this pull request as ready for review August 30, 2024 23:48
.github/workflows/cli.yml Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
openc3/bin/openc3cli Outdated Show resolved Hide resolved
Copy link

sonarcloud bot commented Sep 14, 2024

@ryanmelt ryanmelt merged commit 85d2f56 into main Sep 18, 2024
25 of 27 checks passed
@ryanmelt ryanmelt deleted the cli_script_wait branch September 18, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

openc3cli start script and wait for complete
3 participants