Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] Schrodinger solvation shell extraction #23
base: main
Are you sure you want to change the base?
[DRAFT] Schrodinger solvation shell extraction #23
Changes from 25 commits
c431bea
9c75284
ef3e241
f092257
14749ae
4280670
09031e2
70de4e1
3868637
6b8e9a7
88832da
0af4830
006c1ee
53f52f9
869b81a
bdcb588
3334e95
4a3fcc8
3e5ce54
5e5fff3
6d327fc
e3182e6
2401268
5dcc01c
adc3ebe
9abc9cf
8536dd7
a280702
7edbc07
ea015e7
7b800d6
68fa23c
d46a506
4c5603e
d852562
ce26492
923168c
c460cb7
a26d9bb
42536c3
bad07e7
2e72c49
901567b
db18286
8c2e2e6
cdfbb02
f36e450
46df040
301c199
b56de8d
30ed02c
1c7fd1a
d65860f
ed22d93
82fff88
1ef6e1b
4a55633
66b4afd
ac25b01
46aab0d
af2245b
e0479be
9bc0a70
e31bf22
3ee9aa0
8e2a1e0
b2b836d
cb1139c
f7bd798
68dabb2
ca95322
eb12dd8
f432765
53b6101
1af70a4
4d9f53b
aa7d024
34d2f21
a51ea9b
23e320a
c0f36e8
b487187
b24eac1
d413430
39abfb0
66fcc21
c48f21e
3e65d58
0e54a94
6720a55
3966421
c877a8b
2963480
f225f37
aff9ec2
9657238
e0f2321
dd8e52d
7a05a75
23763fb
02ce480
bd6aa7d
44a56ea
9bcc118
53e4901
bef0a7e
d19e4a7
60f627e
47d9295
514ea62
7b1d14a
07b391d
abf0607
6128728
b3eaf6c
65b9c0b
2cc5793
a477ada
abe6e40
23bcacf
654a8a6
a9b5124
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since so much of this code is identical with the above loop, it would be better to make this a function and call it twice with different arguments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this important for some reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was under the impression that the final outputted files needed to include the partial charge information since it's needed for DFT, so I added it here. But it looks like it's not actually getting written to the output
.xyz
files properly (they still only include positions). Do you have a suggestion on how to do this? Maybe I need to write to PDB format to incorporate charge info?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Final structures need the total charge and spin, not partial charges.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these partial charges actually floats or are they formal charge? If you add all the charges to at.formal_charge then at the end when you have extracted things, you can do st.formal_charge to get the sum of formal charges on all the atoms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The partial charges are floats. But since we only need total charge for DFT, can we do the process you just described? I.e assign all partial charges, and get st.partial_charge at the end to get the sum across all atoms in a shell?