Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "mode" attribute to ExeGeneratorArgumentType #331

Conversation

Torbjorn-Svensson
Copy link
Contributor

This aligns the schema with the documentation.

@Torbjorn-Svensson
Copy link
Contributor Author

@jkrech Can you please take a look at this PR?

Side note, apparently I cannot request reviewer in this git repository.

@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/added-mode-attribute-to-ExeGeneratorArgumentType branch from 9bb9fe0 to 0b9195c Compare October 8, 2024 16:52
This aligns the schema with the documentation.

Signed-off-by: Torbjörn SVENSSON <[email protected]>
@Torbjorn-Svensson Torbjorn-Svensson force-pushed the pr/added-mode-attribute-to-ExeGeneratorArgumentType branch from 0b9195c to a2d82d0 Compare October 8, 2024 16:59
@jkrech jkrech self-requested a review October 8, 2024 17:00
jkrech
jkrech previously approved these changes Oct 10, 2024
Copy link
Member

@jkrech jkrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Thanks for adding the documented mode to the schema

@jkrech jkrech merged commit a6d49e5 into Open-CMSIS-Pack:main Oct 11, 2024
3 checks passed
@Torbjorn-Svensson Torbjorn-Svensson deleted the pr/added-mode-attribute-to-ExeGeneratorArgumentType branch October 11, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants