Add test for loading corrupted metadata #716
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Slawomir Jankowski <[email protected]>
Signed-off-by: Slawomir Jankowski <[email protected]>
Ostrokrzew
force-pushed
the
load_corrupted_test
branch
from
d45acde to
b64a70a
Compare
|
retest this please |
karolinavelkaja
approved these changes
Aug 12, 2021
|
retest this please |
|
Can one of the admins verify this patch? |
Deixx
reviewed
Sep 3, 2024
| title: Security test for loading cache with corrupted metadata. | ||
| description: | | ||
| Validate the ability of Open CAS to load cache instance and work if metadata is corrupted. | ||
| Test 200 times for each configuration. |
There was a problem hiding this comment.
That's why I don't like specific numbers in description ;) iteration_per_config = 1000
| return casadm.set_param_promotion(self.cache_id, promotion_policy) | ||
|
|
||
| def set_params_nhit(self, nhit_params: PromotionParametersNhit): | ||
| return casadm.set_param_promotion_nhit(self.cache_id, |
There was a problem hiding this comment.
should pass PromotionParametersNhit to casadm
checks should be against None (trigger can be 0)
| return output | ||
|
|
||
|
|
||
| def set_param_promotion_nhit(cache_id: int, threshold: int = None, trigger: int = None): |
There was a problem hiding this comment.
should accept PromotionParametersNhit and do proper checks for threshold and trigger against None
Comment on lines
+338
to
+340
| cache_id=cache_id, | ||
| threshold=threshold, | ||
| trigger=trigger)) |
Comment on lines
+261
to
+275
| def set_param_promotion_cmd(cache_id: str, policy: str, shortcut: bool = False): | ||
| add_params = (" -p " if shortcut else " --policy ") + policy | ||
| return _set_param_cmd(namespace="promotion", cache_id=cache_id, | ||
| additional_params=add_params, shortcut=shortcut) | ||
|
|
||
|
|
||
| def set_param_promotion_nhit_cmd(cache_id: str, threshold: str = None, | ||
| trigger: str = None, shortcut: bool = False): | ||
| add_param = "" | ||
| if threshold is not None: | ||
| add_param += (" -t " if shortcut else " --threshold ") + threshold | ||
| if trigger is not None: | ||
| add_param += (" -o " if shortcut else " --trigger ") + trigger | ||
| return _set_param_cmd(namespace="promotion-nhit", cache_id=cache_id, | ||
| additional_params=add_param, shortcut=shortcut) |
|
Moved to #1524 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing setter for promotion policy in test API
Add test for loading corrupted metadata
Update Test Framework
Needs https://github.com/Open-CAS/test-framework/pull/259