add random operation test #1575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kamoppl
force-pushed
the
kamilg/add_random_operation_test
branch
from
9a63bad to
aaceaf5
Compare
Deixx
reviewed
Nov 5, 2024
Comment on lines
84
to
85
| set_param, | ||
| set_param, |
There was a problem hiding this comment.
Suggested change
| set_param, | |
| set_param, | |
| set_param, |
Deixx
reviewed
Nov 5, 2024
| if step_name: | ||
| step_name_list.append(step_name) | ||
| except CmdException: | ||
| step_name_list.append(step_name) |
Deixx
reviewed
Nov 5, 2024
| used_core_devices = devices.get("used_core_devices") | ||
|
|
||
| if not available_cache_devices: | ||
| return None |
There was a problem hiding this comment.
make returns consistent (either just return or return None)
Deixx
reviewed
Nov 8, 2024
Comment on lines
75
to
80
| devices = { | ||
| "used_cache_devices": used_cache_devices, | ||
| "available_cache_devices": available_cache_devices, | ||
| "used_core_devices": used_core_devices, | ||
| "available_core_devices": available_core_devices, | ||
| } |
There was a problem hiding this comment.
I really don't really like the idea of putting the lists in a dict and in each operation function getting them back using the string keys.
Alternatives:
- make the lists global
- define the operation functions within the test so they can access those lists directly
- make a class with the lists as variables
Preferably one of the first two.
Deixx
reviewed
Nov 8, 2024
Signed-off-by: Kamil Gierszewski <[email protected]>
Kamoppl
force-pushed
the
kamilg/add_random_operation_test
branch
from
aaceaf5 to
acff040
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.