Add tests for by-id path #1518
Open
Add tests for by-id path #1518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deixx
reviewed
Sep 13, 2024
Deixx
reviewed
Sep 13, 2024
Deixx
reviewed
Sep 13, 2024
Deixx
reviewed
Sep 13, 2024
Deixx
reviewed
Sep 13, 2024
Deixx
reviewed
Sep 13, 2024
Deixx
reviewed
Sep 13, 2024
katlapinka
force-pushed
the
kasiat/test-by-id-path
branch
from
fbe1fa4 to
fd2a534
Compare
|
Hello @katlapinka! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-11-14 10:27:04 UTC |
katlapinka
force-pushed
the
kasiat/test-by-id-path
branch
from
fd2a534 to
42958a2
Compare
Deixx
previously approved these changes
Sep 13, 2024
katlapinka
force-pushed
the
kasiat/test-by-id-path
branch
from
42958a2 to
431d18f
Compare
Kamoppl
reviewed
Nov 12, 2024
| """ | ||
| title: Test for adding core with by-id path. | ||
| description: | | ||
| Check if OpenCAS accepts by-id path to disks added as cores. |
| - Cores are added to cache with the same path as given | ||
| """ | ||
| with TestRun.step("Prepare partitions for cache and for cores."): | ||
| cache_dev = TestRun.disks['cache'] |
| cache_dev = TestRun.disks['cache'] | ||
| cache_dev.create_partitions([Size(200, Unit.MebiByte)]) | ||
| cache_part = cache_dev.partitions[0] | ||
| core_dev = TestRun.disks['core'] |
Comment on lines
44
to
45
| for i in range(cores_number): | ||
| cache.add_core(core_dev.partitions[i]) |
There was a problem hiding this comment.
for core_dev_part in core_dev.partitions:
cache.add_core(core_dev_part)
| if added_cores_number != cores_number: | ||
| TestRun.fail(f"Expected {cores_number} cores, got {added_cores_number}!") | ||
|
|
||
| for i, core in enumerate(added_cores): |
There was a problem hiding this comment.
How about
'for a,b in zip(added_cores, core_dev.partitions):'
| if listed_cores_number != cores_number: | ||
| TestRun.fail(f"Expected {cores_number} cores, got {listed_cores_number}!") | ||
|
|
||
| for core in listed_cores: |
| def create_init_config(cache, cores, paths): | ||
| init_conf = InitConfig() | ||
|
|
||
| def _add_core(core, path): |
There was a problem hiding this comment.
not sure if creating function to use it once, few lines after definition is best practice
|
|
||
| if len(core_pool_list) != 0: | ||
| TestRun.error(f"No cores expected in core pool. Got {core_pool_list}") | ||
| else: | ||
| TestRun.LOGGER.info("Core pool is ok") | ||
|
|
||
| expected_caches_paths = set([active_cache_path, standby_cache_path]) | ||
| expected_caches_paths = {active_cache_path, standby_cache_path} | ||
| caches_paths = {c["device"] for c in caches_list} |
|
|
||
| if len(core_pool_list) != 0: | ||
| TestRun.error(f"No cores expected in core pool. Got {core_pool_list}") | ||
| else: | ||
| TestRun.LOGGER.info("Core pool is ok") | ||
|
|
||
| expected_caches_paths = set([active_cache_path, standby_cache_path]) | ||
| expected_caches_paths = {active_cache_path, standby_cache_path} |
There was a problem hiding this comment.
Not sure if active_cache_path is correct naming for cache_disk_path
There was a problem hiding this comment.
I assume those names gives us more info what are there caches than "first_cache" and "second_cache" names
| f"Expected the following devices as caches " | ||
| f"{expected_caches_paths}. Got {caches_paths}" | ||
| ) | ||
| else: | ||
| TestRun.LOGGER.info("Caches are ok") | ||
|
|
||
| expected_core_paths = set([active_core_path]) | ||
| expected_core_paths = {active_core_path} |
There was a problem hiding this comment.
Not sure if active_core_path is correct naming for core_disk_path
katlapinka
force-pushed
the
kasiat/test-by-id-path
branch
from
431d18f to
51499a7
Compare
Signed-off-by: Katarzyna Treder <[email protected]>
katlapinka
force-pushed
the
kasiat/test-by-id-path
branch
from
51499a7 to
68ef9f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR:
#931
Needs:
Open-CAS/test-framework#14