Add 'wi' (Write-Invalidate) as valid cache mode #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrea Tomassetti <[email protected]>
|
Can one of the admins verify this patch? |
robertbaldyga
requested changes
Apr 13, 2022
| @@ -292,7 +292,7 @@ def check_cache_device_empty(self): | |||
| ) | |||
|
|
|||
| def check_cache_mode_valid(self, cache_mode): | |||
| if cache_mode not in ['wt', 'pt', 'wa', 'wb', 'wo']: | |||
| if cache_mode not in ['wt', 'pt', 'wa', 'wb', 'wo', 'wi']: | |||
There was a problem hiding this comment.
On the other hand when experimental features are disabled (which is default), WI should not be recognized as a valid cache mode. This option should be accepted only conditionally. The problem is that we currently do not have any good way to recognize whether OpenCAS was compiled with experimental features enabled, so this is another thing to be implemented in order to make casctl work with Write-Invalidate.
There was a problem hiding this comment.
Shouldn't, at some point, some C function fails if WI was not enabled during compile time? Making this patch "safe" even when WI is disabled? For example:
inline int validate_str_cache_mode(const char *s)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling experimental Write-Invalidate cache mode,
casctl initfails without this patch.Signed-off-by: Andrea Tomassetti [email protected]