Fix Farore's Wind recast textbox in multiworld #2341
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #2302, it seems like the change to Farore's Wind recast textbox doesn't play well in multiworld due to the work done by the make_player_message function to switch the uses of "You something something" to "Player name something something", that kinda breaks the custom control codes used.
Thanks to Blueinfinity's on Discord for the report :
As discussed with Fenhl, a simple solution is to move the textbox listing from ITEM_MESSAGES to MISC_MESSAGES instead, which will prevent any further change done for multiworld.