Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Farore's Wind recast textbox in multiworld #2341

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Dec 29, 2024

Following #2302, it seems like the change to Farore's Wind recast textbox doesn't play well in multiworld due to the work done by the make_player_message function to switch the uses of "You something something" to "Player name something something", that kinda breaks the custom control codes used.

Thanks to Blueinfinity's on Discord for the report :
image

As discussed with Fenhl, a simple solution is to move the textbox listing from ITEM_MESSAGES to MISC_MESSAGES instead, which will prevent any further change done for multiworld.

@fenhl fenhl added Type: Bug Something isn't working Status: Needs Testing Probably should be tested Component: Patching Affects the patching of the ROM labels Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Patching Affects the patching of the ROM Status: Needs Testing Probably should be tested Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants