Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix key rings being hinted as small key when keys are in their own dungeons #2317

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Oct 19, 2024

If a keyring is placed on a hinted spot but keys are in their own dungeons, it will be hinted as a Small key, because it will be treated as an Unshuffled dungeon item, and default back to its type name, which is currently SmallKey.

To reproduce, use a hint distribution that hints Skull Mask as always, put small keys in their own dungeons and plando a keyring on Skull Mask :

  "locations":                 {
    "Deku Theater Skull Mask":                              "Small Key Ring (Forest Temple)"
  }

The fix proposed is to give their own types to keyrings, and give it a generic type hint which will be used in this case.

@cjohnson57 cjohnson57 added Type: Bug Something isn't working Status: Needs Review Someone should be looking at it Component: Hints related to how we help the player labels Oct 19, 2024
@cjohnson57 cjohnson57 added Status: Waiting for Maintainers and removed Status: Needs Review Someone should be looking at it labels Oct 19, 2024
HintList.py Show resolved Hide resolved
HintList.py Outdated Show resolved Hide resolved
@fenhl fenhl added Status: Waiting for Author Changes or response requested and removed Status: Waiting for Maintainers labels Oct 19, 2024
@fenhl fenhl removed the Status: Waiting for Author Changes or response requested label Oct 22, 2024
@fenhl fenhl added this to the next milestone Oct 22, 2024
@fenhl fenhl merged commit 0eb9b9b into OoTRandomizer:Dev Oct 22, 2024
3 checks passed
@GSKirox GSKirox deleted the keyring_hint_fix branch October 27, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Hints related to how we help the player Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants