Fix key rings being hinted as small key when keys are in their own dungeons #2317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a keyring is placed on a hinted spot but keys are in their own dungeons, it will be hinted as a Small key, because it will be treated as an Unshuffled dungeon item, and default back to its type name, which is currently SmallKey.
To reproduce, use a hint distribution that hints Skull Mask as always, put small keys in their own dungeons and plando a keyring on Skull Mask :
The fix proposed is to give their own types to keyrings, and give it a generic type hint which will be used in this case.