Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stick/Nut Upgrade Model Improvements #2313

Open
wants to merge 3 commits into
base: Dev
Choose a base branch
from
Open

Stick/Nut Upgrade Model Improvements #2313

wants to merge 3 commits into from
+16,440 −16,207

Conversation

rrealmuto
Copy link

This PR adds a flame/smoke effect to the stick/nut upgrade GI models as shown below.

GLideN64_THE_LEGEND_OF_ZELDA_081
GLideN64_THE_LEGEND_OF_ZELDA_080
GLideN64_THE_LEGEND_OF_ZELDA_079
GLideN64_THE_LEGEND_OF_ZELDA_078

@fenhl fenhl added Type: Enhancement New feature or request Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described labels Oct 1, 2024
@RawZ06
Copy link

RawZ06 commented Oct 1, 2024

It would be nice to have a same effect for magic meter maybe ?

GSKirox
GSKirox requested changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@GSKirox GSKirox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of formatting nitpicks

ASM/c/item_draw_functions.h Outdated Show resolved Hide resolved
ASM/c/item_draw_functions.c Outdated Show resolved Hide resolved
@fenhl fenhl added the Status: Waiting for Author Changes or response requested label Oct 28, 2024
@fenhl fenhl requested a review from GSKirox December 26, 2024 01:41
@fenhl fenhl removed the Status: Waiting for Author Changes or response requested label Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GSKirox GSKirox Awaiting requested review from GSKirox

Assignees
No one assigned
Labels
Component: ASM/C Changes some internals of the ASM/C libraries Status: Needs Review Someone should be looking at it Status: Under Consideration Developers are considering whether to accept or decline the feature described Type: Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rrealmuto @RawZ06 @GSKirox @fenhl