Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent enabling password without either spoiler log on or defining one via plando #2310

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Prevent enabling password without either spoiler log on or defining one via plando #2310

merged 1 commit into from
Sep 24, 2024

Conversation

GSKirox
Copy link
Collaborator

@GSKirox GSKirox commented Sep 24, 2024

To avoid situations where someone locks their seed without having a way to know the password.
This raises an exception when generating in this case.

@fenhl fenhl added Type: Bug Something isn't working Component: Plandomizer Plandomizer library and functionality Status: Needs Testing Probably should be tested Component: Documentation Affects user-facing help messages or public API docs and removed Status: Needs Testing Probably should be tested labels Sep 24, 2024
@fenhl fenhl added this to the next milestone Sep 24, 2024
@fenhl fenhl merged commit c0deb7a into OoTRandomizer:Dev Sep 24, 2024
3 checks passed
@GSKirox GSKirox deleted the password_spoiler branch October 1, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fenhl fenhl fenhl approved these changes

Assignees
No one assigned
Labels
Component: Documentation Affects user-facing help messages or public API docs Component: Plandomizer Plandomizer library and functionality Type: Bug Something isn't working
Projects
None yet
Milestone
8.2
Development

Successfully merging this pull request may close these issues.
2 participants
@GSKirox @fenhl