Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider free scarecrow in logic without ocarina buttons #2221

Open
wants to merge 1 commit into
base: Dev
Choose a base branch
from

Conversation

fenhl
Copy link
Collaborator

@fenhl fenhl commented May 13, 2024

As pointed out by @r0bd0g in #dev-glitchless-logic today, you don't actually need any ocarina buttons to summon Pierre in free scarecrow. So this PR adjusts the logic accordingly.

@fenhl fenhl added Type: Bug Something isn't working Component: Logic Non-trivial changes to the JSON logic files Status: Needs Review Someone should be looking at it Status: Needs Testing Probably should be tested labels May 13, 2024
@fenhl
Copy link
Collaborator Author

fenhl commented Jun 2, 2024

Tested using this plando, which generates successfully on this PR but not on Dev:

{
    "settings": {
        "open_forest": "open",
        "open_door_of_time": true,
        "shuffle_individual_ocarina_notes": true,
        "free_scarecrow": true,
        "shuffle_tcgkeys": "keysanity",
        "tokensanity": "all"
    },
    "locations": {
        "Bongo Bongo": "Shadow Medallion",
        "Dodongos Cavern GS Scarecrow": "Small Key (Treasure Chest Game)",
        "Market Treasure Chest Game Room 1 Bottom": "Small Key (Treasure Chest Game)",
        "Market Treasure Chest Game Room 2 Bottom": "Small Key (Treasure Chest Game)",
        "Market Treasure Chest Game Room 3 Bottom": "Small Key (Treasure Chest Game)",
        "Market Treasure Chest Game Room 4 Bottom": "Small Key (Treasure Chest Game)",
        "Market Treasure Chest Game Room 5 Bottom": "Small Key (Treasure Chest Game)",
        "Market Treasure Chest Game Room 1 Top": "Ocarina A Button",
        "Market Treasure Chest Game Room 2 Top": "Ocarina C down Button",
        "Market Treasure Chest Game Room 3 Top": "Ocarina C left Button",
        "Market Treasure Chest Game Room 4 Top": "Ocarina C right Button",
        "Market Treasure Chest Game Room 5 Top": "Ocarina C up Button",
        "Market Treasure Chest Game Reward": "Progressive Hookshot"
    }
}

@fenhl fenhl removed the Status: Needs Testing Probably should be tested label Jun 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Logic Non-trivial changes to the JSON logic files Status: Needs Review Someone should be looking at it Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant