This repository has been archived by the owner on Nov 5, 2024. It is now read-only.
MV: Install openapi2json to convert schemas for kubeconform validation #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-cook
reviewed
Jun 19, 2022
| @@ -1,5 +1,12 @@ | |||
| FROM cimg/ruby:3.1.1 | |||
|
|
|||
| RUN sudo apt update && \ | |||
There was a problem hiding this comment.
do we need this? can we not use a python base image in the ci flow somewhere to grab the schema?
There was a problem hiding this comment.
Hmmm,
It means we would need to download the schema using a different image and then save that in CI and then restore that in the kubeconform image when it does validation.
I guess we can do that as well, not sure what is cleaner to have two images run, one to pull schema and second to validate manifests against schema.
Or to have those tasks run within a single container.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.