Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump OneSignal Android SDK #759

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Bump OneSignal Android SDK #759

merged 3 commits into from
Sep 12, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Sep 12, 2024

Description

One Line Summary

Updates included OneSignal Android SDK from 5.1.20 to 5.1.21

Details

Motivation

Apply fixes made in the native OneSignal Android SDK to the Unity wrapper SDK.

Scope

Updated included Android SDK from 5.1.20 to 5.1.21

  • Fix ending an already ended session
  • Fix permissions returned by onRequestPermissionResult when the list is empty
  • Fix keyboard input in HTML in-app messages

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@shepherd-l shepherd-l merged commit 454c42d into main Sep 12, 2024
1 check passed
@shepherd-l shepherd-l deleted the bumpOneSignalAndroidSDK branch September 12, 2024 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants