Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Bump OneSignal Android and iOS SDK versions #743

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Jul 3, 2024

Description

One Line Summary

Updates included OneSignal Android SDK from 5.1.13 to 5.1.17 and OneSignal iOS SDK from 5.2.0 to 5.2.2

Details

Motivation

Applies fixes made in the native SDKs to the Unity wrapper SDK.

Scope

Updates included Android SDK from 5.1.13 to 5.1.17

  • Fixes Xiaomi notification click not foregrounding app
  • Fixes FCM push token not being refreshed
  • Poll for notification permission changes to detect permission change when prompting outside of OneSignal
  • Cold start creates new session and refreshes the user from the server
  • Immediately process pending operations when privacy consent goes from false to true
  • Fixes OneSignal.Notifications.RequestPermissionAsync() not firing when permission was already granted
  • Fixes Operation Model Store adding duplicate operations when the same ones that were previously added to the store and persisted, are re-read from cache
  • Fixes a bug causing clicking an unexpanded group notification results in only registering the click result for the final notification in the group
  • For full changes, see the native release notes

Updates included iOS SDK from 5.2.0 to 5.2.2

  • Prevent In-App Message request crashes by making null values safe
  • Added Dispatch Queues to all executors to prevent concurrency crashes
  • Fixes clearing notifications incorrectly such as when pulling down the notification center
  • Fixes a purchases bug for the amount spent
  • Fixes a build issue for mac catalyst
  • Fixes crash when IAM window fails to load by using the main thread
  • Network call optimizations: Combine user property updates for network call improvements
  • For full changes, see the native release notes

Testing

Manual testing

Tested OneSignal initialization, app build with Unity 2022.3.10f1 of the OneSignal example app on a emulated Pixel 4 with Android 12 and a physical iPhone 12 with iOS 17.5.1.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@shepherd-l shepherd-l requested a review from jkasten2 July 3, 2024 18:48
@shepherd-l shepherd-l merged commit 460cabe into main Jul 3, 2024
1 check passed
@shepherd-l shepherd-l deleted the feature/bumpNativeOneSignalSDKs branch July 3, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants