Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Documentation nits #647

Merged
merged 5 commits into from
Oct 4, 2023
Merged

Conversation

shepherd-l
Copy link
Contributor

@shepherd-l shepherd-l commented Oct 4, 2023

Description

One Line Summary

Fix nits in migration guide and readme

Details

Motivation

Clean up documentation

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
  • I have reviewed this PR myself, ensuring it meets each checklist item

This change is Reviewable

@shepherd-l shepherd-l merged commit bb6bb45 into user-model/main Oct 4, 2023
1 check passed
@shepherd-l shepherd-l deleted the fix/documentationNits branch October 4, 2023 19:59
jinliu9508 pushed a commit that referenced this pull request Feb 23, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
jinliu9508 pushed a commit that referenced this pull request Feb 27, 2024
jinliu9508 pushed a commit that referenced this pull request Mar 1, 2024
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
jinliu9508 pushed a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants