-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] iOS notifications clicked event to fire on cold start #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkasten2
requested changes
Sep 26, 2023
jkasten2
approved these changes
Sep 26, 2023
shepherd-l
changed the title
[Fix] iOS notifications clicked event on app open
[Fix] iOS notifications clicked event to fire on cold start
Sep 26, 2023
1 task
jinliu9508
pushed a commit
that referenced
this pull request
Feb 23, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Feb 27, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Mar 1, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] iOS notifications clicked event on app open
jinliu9508
pushed a commit
that referenced
this pull request
Mar 4, 2024
[Fix] iOS notifications clicked event on app open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
One Line Summary
Fixes iOS notifications clicked event to fire when the app was cold started from clicking a notification.
Details
Motivation
Fixes #638 iOS bug where Notifications.Clicked event is set but does not fire when clicking the notification cold starts the app.
Testing
Manual testing
Tested clicking on notifications when the app in the foreground, background, and closed, app build with Unity 2021.3.16f1 of the OneSignal example app on a physical iPhone 12 with iOS 15.5.
Affected code checklist
Checklist
Overview
Testing
Final pass
This change is